Skip to content

fix(table): ignore BOM #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 10, 2024
Merged

fix(table): ignore BOM #757

merged 4 commits into from
Dec 10, 2024

Conversation

caarlos0
Copy link
Member

  • discards BOM
  • closes file opened

closes #520

@caarlos0
fix(table): ignore BOM
72889bd 
closes #520

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added bug Something isn't working cmd/table labels Dec 10, 2024
@caarlos0 caarlos0 self-assigned this Dec 10, 2024
@caarlos0
fix: lint issue
78b2302 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
fix: simplify
12a49cb
@caarlos0
fix: better error
9736d26
@caarlos0 caarlos0 merged commit cc71f60 into main Dec 10, 2024
14 checks passed
@caarlos0 caarlos0 deleted the bom branch December 10, 2024 17:45
@bashbunni bashbunni added this to the v0.15.0 milestone Jan 12, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working cmd/table
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

CSV exports that contain "BOM" cause gum table to break
2 participants
@caarlos0 @bashbunni