Skip to content

Conversation

meowgorithm
Copy link
Member

This reverts commit 1d07efd.

We're reverting this due to a bug where timeout is printed on timeout. Additonally:

  • This should also default to seconds when no unit is specified (i.e. --timeout=5)
  • We should show a timeout indicator in the UI

We'll address these and re-add this after the next release.

@meowgorithm meowgorithm requested a review from aymanbagabas July 24, 2024 19:24
@meowgorithm meowgorithm requested a review from maaslalani as a code owner July 24, 2024 19:24
@meowgorithm meowgorithm changed the title revert: "added timeout option to choose and other patches (maybe) (#6… revert: "add timeout option to choose" (#618) Jul 24, 2024
@meowgorithm meowgorithm merged commit ecb57b7 into main Jul 24, 2024
@meowgorithm meowgorithm deleted the revert-timeout branch July 24, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant