Skip to content

generated completion invalid for fish shell #821

@nate-duke

Description

@nate-duke

Describe the bug
A recent change rendered the generated completion files for the fish shell with a quoting issue. The issue is a pair of single quotes around an asterisk.

complete -c gum -f -n '__fish_seen_subcommand_from choose' -x -l selected -d 'Options that should start as selected (selects all if given '*')'

To Reproduce
Steps to reproduce the behavior:

  1. install gum (i did this via homebrew for linux)
  2. use fish shell
  3. See error

Expected behavior
No parsing errors in completion scripts.

Screenshots

/home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/gum.fish (line 24): No matches for wildcard ''Options that should start as selected (selects all if given '*')''. See `help wildcards-globbing`.
complete -c gum -f -n '__fish_seen_subcommand_from choose' -x -l selected -d 'Options that should start as selected (selects all if given '*')'
                                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file /home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/gum.fish
        called on line 8 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
        called during startup
/home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/gum.fish (line 91): No matches for wildcard ''Options that should start as selected (selects all if given '*')''. See `help wildcards-globbing`.
complete -c gum -f -n '__fish_seen_subcommand_from filter' -x -l selected -d 'Options that should start as selected (selects all if given '*')'
                                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file /home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/gum.fish
        called on line 8 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
        called during startup
🐟

Desktop (please complete the following information):

  • Debian 12

Additional context
I looked around the completion generation code in the repo but can't pinpoint exactly what changed or where a fix could be performed. I'm not terribly familiar with the codebase.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions