-
Notifications
You must be signed in to change notification settings - Fork 966
(v2) feat: use the cursed renderer #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How should we test this? |
7271090
to
bdd75f3
Compare
You can use export TEA_EXPERIMENTAL=ferocious
// run bubble tea applications EDIT: This is no longer needed as the ferocious cursed renderer is now the default and only available renderer. |
caarlos0
approved these changes
Dec 10, 2024
c308816
to
9d780bc
Compare
caarlos0
approved these changes
Dec 12, 2024
70c0468
to
fda3865
Compare
20611ed
to
b76f7d5
Compare
73d0ffd
to
4b2b55b
Compare
Testing Ferocious Renderer
IMAGES VIDEOS 2024-12-16.07-14-22.mov2024-12-16.06-50-40.mov |
fdf22bc
to
317c49f
Compare
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.28.0 to 0.29.0. - [Commits](golang/sys@v0.28.0...v0.29.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rd renderer This also removes the experimental flags and changes the renderer interface to be more explicit about the methods that are available.
3c55968
to
ffa5bf4
Compare
…#1289) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.27.0 to 0.33.0. - [Commits](golang/net@v0.27.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1290) Bumps [github.com/charmbracelet/x/ansi](https://github.com/charmbracelet/x) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/charmbracelet/x/releases) - [Commits](charmbracelet/x@ansi/v0.6.0...ansi/v0.7.0) --- updated-dependencies: - dependency-name: github.com/charmbracelet/x/ansi dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
meowgorithm
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new cursed ferocious renderer. This is based on the new
cellbuf.Screen
renderer. This renderer is more efficient and flexible than the previous renderer.The renderer controls the altscreen buffer and cursor visibility which means we don't need to do so in Bubble Tea. Instead, Bubble Tea can focus on the event loop and the application state.
This also removes the experimental flags and changes the renderer
interface to be more explicit about the methods that are available.