feat: allow for using CRUSH_ prefixed env-vars without clobbering default env vars #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obbering AWS env vars
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
|
hey @kujtimiihoxha , I made the CRUSH_ prefix logic generic as discussed. |
|
@taigrr do you think its worth adding this in the docs? |
|
Yeah, should be added to docs, as you see fit |
caarlos0
reviewed
Jul 31, 2025
caarlos0
reviewed
Jul 31, 2025
|
I think we could do this in |
|
Could! This works for me if there's a better way please go for it |
|
hey @kujtimiihoxha any updates on the plans for this? Hoping to deploy next week. |
kujtimiihoxha
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
talked to @caarlos0 about the implications of doing this another way and I think for now this is OK
caarlos0
reviewed
Aug 7, 2025
caarlos0
approved these changes
Aug 7, 2025
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
…ault env vars (charmbracelet#391) * feat: allow for using CRUSH_ prefixed env-vars for bedrock without clobbering AWS env vars * feat: make the CRUSH_ prefix generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add ability to push/pop
CRUSH_-prefixed env vars for anthropic/bedrock.CONTRIBUTING.mdBasically, when developing actively on AWS, we might want to use crush in our AWS environment using credentials that are not the same as the credentials that are used for the bedrock instance.
This PR adds a function that allows for Push/Pop of the relevant
AWS_*env vars when running in bedrock mode