sec: remove 'go' from safe programs #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be used to prompt inject commands e.g. `go test -exec`. Plus, we don't have other languages there, so I think we remove Go as well. Ideally, we could ask haiku if the command is read only or not, and ask for perms based on that, but for now I think this will do. Thanks Will Vandevanter for the report. Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
andreynering
approved these changes
Aug 18, 2025
raphamorim
approved these changes
Aug 18, 2025
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
It could be used to prompt inject commands e.g. `go test -exec`. Plus, we don't have other languages there, so I think we remove Go as well. Ideally, we could ask haiku if the command is read only or not, and ask for perms based on that, but for now I think this will do. Thanks Will Vandevanter for the report. Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be used to prompt inject commands e.g.
go test -exec.Plus, we don't have other languages there, so I think we remove Go as well.
Ideally, we could ask haiku if the command is read only or not, and ask for perms based on that, but for now I think this will do.
Thanks Will Vandevanter for the report.