fix(tui): Prevent dialog keymaps from being swallowed #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
This change checks for the presence of a dialog before checking for other handlers. Now when pressing ctrl+p when a dialog is visible it will correctly navigate up the list. This restores the standard terminal behavior of using ctrl+n and ctrl+p. How to reproduce: 1. ctrl+p to open for the command launcher 2. ctrl+n (or down) to move down one item 3. ctrl+p - command dialog closed With this fix, step 3. will now correctly select the previous item in the dialog.
bf42fa0 to
c9d2b3a
Compare
andreynering
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
Thank you for contributing @uri!
I tested and this is working great.
The push I made to your branch was just to fix a conflict that appeared since you opened the PR.
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
) This change checks for the presence of a dialog before checking for other handlers. Now when pressing ctrl+p when a dialog is visible it will correctly navigate up the list. This restores the standard terminal behavior of using ctrl+n and ctrl+p. How to reproduce: 1. ctrl+p to open for the command launcher 2. ctrl+n (or down) to move down one item 3. ctrl+p - command dialog closed With this fix, step 3. will now correctly select the previous item in the dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This change checks for the presence of a dialog before checking for other handlers.
Now when pressing ctrl+p when a dialog is visible it will correctly navigate up the list. This restores the standard terminal behavior of using ctrl+n and ctrl+p.
How to reproduce:
With this fix, step 3. will now correctly select the previous item in the dialog.
Checklist before requesting a review
CONTRIBUTING.md