fix(gemini): tool-calling panic issue #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calls Signed-off-by: sami <sami@appscode.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
andreynering
approved these changes
Aug 14, 2025
caarlos0
approved these changes
Aug 14, 2025
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The issue was apparently that the go-genai module expects the roles in the chat history to be either "user" or "model". Since the tool calls in the history were assigned the role "function", combined with the fact that the chat creation errors were being ignored, resulted in this cryptic/weird issue. This pr introduces a workaround by attributing the tool-call's output to the model.
Steps to validate the fix:
PS: I'm not sure if this is a "proper fix", since the tool call results shouldn't most likely be attributed to the model in the history.
Related issue/discussion: #768, #771
Checklist before requesting a review
CONTRIBUTING.mdIf this is a feature