fix(fsext): prevent .* gitignore from ignoring entire root dir #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed critical bug where gitignore patterns like .* would match the root directory itself, causing filepath.SkipDir to abort entire file listing. The fix prevents gitignore rules from applying to the scan root directory, matching Git's actual behavior. Also fixed typos in debug log messages (ingoring -> ignoring).
caarlos0
approved these changes
Aug 14, 2025
caarlos0
reviewed
Aug 14, 2025
caarlos0
reviewed
Aug 14, 2025
andreynering
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
I tested and this is working as expected now. Thank you @jamestrew!
|
I had to push a simple fix for tests not passing on Windows. |
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
…harmbracelet#766) Fixed critical bug where gitignore patterns like `.*` would match the root directory itself, causing `filepath.SkipDir` to abort entire file listing. The fix prevents gitignore rules from applying to the scan root directory, matching Git's actual behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed critical bug where gitignore patterns like .* would match the root directory itself, causing filepath.SkipDir to abort entire file listing. The fix prevents gitignore rules from applying to the scan root directory, matching Git's actual behavior.
Also fixed typos in debug log messages (ingoring -> ignoring).
Related issue/discussion: closes #765
Checklist before requesting a review
CONTRIBUTING.md