fix: Expose Required params to Anthropic API #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
c60db5d to
fd94a60
Compare
|
Also fixed the
|
Added a build task for parity with other task commands. Used the suggested build command from the README. Also added "generates" annotations, which is useful as the Taskfile grows. Signed-off-by: Evan Wies <evan@neomantra.net>
Signed-off-by: Evan Wies <evan@neomantra.net>
Signed-off-by: Evan Wies <evan@neomantra.net>
caarlos0
approved these changes
Aug 14, 2025
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
andreynering
approved these changes
Aug 14, 2025
|
thanks @neomantra 🙏🏻 |
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
* chore: add build task and generates annotations Added a build task for parity with other task commands. Used the suggested build command from the README. Also added "generates" annotations, which is useful as the Taskfile grows. Signed-off-by: Evan Wies <evan@neomantra.net> * fix: expose Required params to Anthropic client Signed-off-by: Evan Wies <evan@neomantra.net> * fix: typo in cla.yml precomment -> prcomment Signed-off-by: Evan Wies <evan@neomantra.net> --------- Signed-off-by: Evan Wies <evan@neomantra.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I added a simple build task (for parity) and bridged the
Requiredparameters from the internalcrushstruct (extracted frommcp-go) to the Anthropic API struct.I have self-reviewed my code and implemented this through inspection of the three repos. That said, I have not end-to-end tested it, i.e. having a test with Required args and seeing if Claude honors it, etc. I assumed this code was omitted due to project velocity and not that there was some specific issue.
Also fixed the CLA.
Checklist before requesting a review
CONTRIBUTING.md