fix(lsp): return a copy of lsp diagnostics to avoid data race #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
60ff41f to
a7d5428
Compare
bbrodriges
reviewed
Aug 9, 2025
internal/lsp/client.go
Outdated
| defer c.diagnosticsMu.RUnlock() | ||
|
|
||
| diagnostics := make(map[protocol.DocumentURI][]protocol.Diagnostic, len(c.diagnostics)) | ||
| maps.Copy(diagnostics, c.diagnostics) |
caarlos0
approved these changes
Aug 11, 2025
bbrodriges
approved these changes
Aug 11, 2025
|
Thanks! |
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
…racelet#681) * fix(lsp): return a copy of lsp diagnostics to avoid data race * Replace maps.Copy with maps.Clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Return a copy of lsp diagnostics in
GetDiagnosticsto avoid data race.Previously, the internal map is returned directly. Other goroutines can read it without lock.
Related issue/discussion:
Checklist before requesting a review
CONTRIBUTING.mdIf this is a feature