fix(mcp): give a time limit for startup #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a MCP gets stuck starting/connecting, chatting will not work. This makes it so it'll timeout after 5s (we can discuss the time), and then everything works accordingly. Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
andreynering
approved these changes
Aug 8, 2025
Co-authored-by: Andrey Nering <andreynering@users.noreply.github.com>
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
* fix(mcp): give a time limit for startup If a MCP gets stuck starting/connecting, chatting will not work. This makes it so it'll timeout after 5s (we can discuss the time), and then everything works accordingly. Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: spinner Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * Update mcp-tools.go Co-authored-by: Andrey Nering <andreynering@users.noreply.github.com> --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: Andrey Nering <andreynering@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a MCP gets stuck starting/connecting, chatting will not work.
This makes it so it'll timeout after 5s (we can discuss the time), and then everything works accordingly.