Skip to content

fix(tools): do not truncate output #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

fix(tools): do not truncate output #657

merged 1 commit into from
Aug 8, 2025

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 8, 2025

This may cause more problems than it fixes, as for instance, it cuts json responses as well, rendering them invalid.

@caarlos0
fix(tools): do not truncate output
d87b258 
This may cause more problems than it fixes, as for instance, it cuts
json responses as well, rendering them invalid.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Aug 8, 2025
@caarlos0 caarlos0 requested a review from kujtimiihoxha as a code owner August 8, 2025 16:48
andreynering
andreynering approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we want to add this back later, but in a more careful manner: no "width" cutting and only where it makes sense.

@caarlos0
Copy link
Member Author

caarlos0 commented Aug 8, 2025

I suppose we want to add this back later, but in a more careful manner: no "width" cutting and only where it makes sense.

yes, I'm working on having a better alternative using tiktoken

@caarlos0 caarlos0 merged commit e00a70a into main Aug 8, 2025
20 checks passed
@caarlos0 caarlos0 deleted the tool branch August 8, 2025 17:13
scalabl3 pushed a commit to metaphori-ai/crush that referenced this pull request Aug 19, 2025
@caarlos0
fix(tools): do not truncate output (charmbracelet#657)
aa1986d 
This may cause more problems than it fixes, as for instance, it cuts
json responses as well, rendering them invalid.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

@andreynering andreynering andreynering approved these changes

@kujtimiihoxha kujtimiihoxha Awaiting requested review from kujtimiihoxha

Assignees

@caarlos0 caarlos0

Labels
area: tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caarlos0 @aymanbagabas @andreynering @charmcli