-
Notifications
You must be signed in to change notification settings - Fork 571
feat: enable steering the model while in the loop #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the queue pill to the tui - allow esc to clear the queu
81ee554
to
b4021a5
Compare
caarlos0
reviewed
Aug 8, 2025
Comment on lines
+449
to
+461
// If there are queued prompts, process the next one | ||
nextPrompt, ok := a.promptQueue.Take(sessionID) | ||
if ok { | ||
for _, prompt := range nextPrompt { | ||
// Create a new user message for the queued prompt | ||
userMsg, err := a.createUserMessage(ctx, sessionID, prompt, nil) | ||
if err != nil { | ||
return a.err(fmt.Errorf("failed to create user message for queued prompt: %w", err)) | ||
} | ||
// Append the new user message to the conversation history | ||
msgHistory = append(msgHistory, userMsg) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this runs in both branches of the if, maybe move it outside?
caarlos0
reviewed
Aug 8, 2025
caarlos0
reviewed
Aug 8, 2025
caarlos0
reviewed
Aug 8, 2025
caarlos0
reviewed
Aug 8, 2025
caarlos0
reviewed
Aug 8, 2025
caarlos0
reviewed
Aug 8, 2025
caarlos0
reviewed
Aug 8, 2025
meowgorithm
approved these changes
Aug 12, 2025
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
* feat: enable steering the model while in the loop * feat: show queued messages in the TUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow staring the llm in the loop without having to stop it.
Screen.Recording.2025-08-08.at.12.42.49.mov