chore: rename default theme + infer default theme name #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the default theme management by renaming the default theme from "crush" to "charmtone" and improving the theme initialization logic to prevent potential panics when the expected default theme name doesn't match.
- Renamed default theme from "crush" to "charmtone"
- Modified
NewManager()to infer the default theme name instead of hardcoding it - Removed the hardcoded default theme parameter from
NewManager()
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/tui/styles/theme.go | Updated theme manager to remove hardcoded default theme name and infer it dynamically |
| internal/tui/styles/charmtone.go | Renamed theme function and name from "crush" to "charmtone" |
|
@meowgorithm this needs a rebase/merge |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9d2834c to
272f2d2
Compare
|
Rebased on |
scalabl3
pushed a commit
to metaphori-ai/crush
that referenced
this pull request
Aug 19, 2025
…#570) * chore: rename default theme + infer default theme name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revision: