Skip to content

Adapt to https://github.com/coq/coq/pull/19530 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2024
Merged

Adapt to https://github.com/coq/coq/pull/19530 #22

merged 1 commit into from
Oct 30, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Sep 17, 2024

Adapt to rocq-prover/rocq#19530
This is an adaptation in anticipation of the day the temporary backward compatibility introduced in the upstream PR will be removed (probably a few years in the future).
Merging this is not required for the upstream PR, you can do whatever you want with it.

@proux01 proux01 mentioned this pull request Sep 17, 2024
Merged
43 tasks
@charguer charguer merged commit 1a68190 into charguer:master Oct 30, 2024
@charguer
Copy link
Owner

Thanks. Yet, I had to change the require command to From Coq Requires ..., because otherwise it wouldn't compile on Coq 8.18. I do not quite understand what is the migration plan. If I understand well, I will need to replace From Coq by From Stdlib, but I'd like to do so while remaining compatible over several versions of Coq. How is that going to work?

@proux01
Copy link
Contributor Author

proux01 commented Oct 30, 2024

From Coq will keep working for a few versions (likely a few years) so you can either:

  • wait until you drop support for Coq 8.20 to introduce the From Stdlib
  • introduce From Coq now, silence the warning in _CoqProject and replace Coq with Stdlib when droping Coq 8.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proux01 @charguer