Fix crash when debug logging is enabled and passed empty string #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please make a new release with this patch? This is breaking our usage of aiohttp. |
moz-v2v-gh
pushed a commit
to mozilla-releng/build-puppet
that referenced
this pull request
May 15, 2017
I updated a number of python packages. One of them is chardet==3.0.2, which doesn't contain this PR [1], which fixes a crash when we use chardet with debug logging. We don't directly call chardet, but aiohttp does, so we're crashing during beetmover uploads. Downgrading chardet until there's a new chardet>3.0.2 that fixes this issue. [1] chardet/chardet#117
|
Will release 3.0.3 with #125 hotfix today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115