Skip to content

Change labelColors to labelColor in tooltip drawColorBox method. #11135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2023
Merged

Change labelColors to labelColor in tooltip drawColorBox method. #11135

merged 1 commit into from
Feb 12, 2023

Conversation

leo2436
Copy link
Contributor

@leo2436 leo2436 commented Feb 12, 2023

This pr change variable labelColors to labelColor because it is a member of this.labelColors, thus should use singular.

@etimberg etimberg added this to the Version 4.3.0 milestone Feb 12, 2023
@etimberg etimberg merged commit 6cf9de9 into chartjs:master Feb 12, 2023
@raymondhtet raymondhtet mentioned this pull request May 29, 2024
Closed
@wanissr wanissr mentioned this pull request Jun 22, 2024
Open
@bwilliford bwilliford mentioned this pull request Jun 26, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Jul 5, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Jul 14, 2024
Closed
@faragashraf faragashraf mentioned this pull request Jul 18, 2024
Open
@scottwad scottwad mentioned this pull request Sep 24, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 24, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Sep 25, 2024
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 4.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@leo2436 @etimberg @LeeLenaleee @leoChen1996