Skip to content

Conversation

bdewilde
Copy link
Collaborator

@bdewilde bdewilde commented Aug 15, 2020

Description

  • adds automated GitHub workflows for building and testing the package, linting and formatting, publishing new releases to PyPi, and building documentation (and removes the old Travis configuration)
  • improves and tidies package configuration: bounds some dependencies, moves source code into a top-level src directory
  • improves and configures dev tooling: adds a makefile with common commands, adds flake8 for linting, sets default tool configurations in setup and pyproject files
  • uses the above tools and actions to significantly improve code consistency and reduce code smell throughout the code base

TODO:

  • update package documentation, especially the contributing guide
  • really get a handle on documentation: will readthedocs work? does the GitHub action do what we think??

Motivation and Context

I've had limited time to maintain and improve textacy for the past year, and much of the available time was spent on reactive / rote maintenance. Taking advantage of newer tools to reduce the maintenance burden will free up time for more meaningful improvements.

How Has This Been Tested?

All the tests run automatically :)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation, and I have updated it accordingly.

maybe this will let the package build...
is this going to trigger a run for branches off these? let's find out!
it would be really fucking nice if pytest could find textacy
windows didn't like downloading spacy language models, and that's not a problem i care to own
@bdewilde bdewilde merged commit d144383 into master Aug 16, 2020
@bdewilde bdewilde deleted the update-package-config branch August 16, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant