Skip to content

Drop PY2 support, and update PY3-only code #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jul 23, 2019
Merged

Conversation

bdewilde
Copy link
Collaborator

@bdewilde bdewilde commented Jul 23, 2019

Description

  • remove the PY2/3 compat module, and replace all calls to it with PY3's built-in functionality
  • remove PY2 builds from Travis and AppVeyor
  • remove PY2-specific dependencies from requirements and setup files
  • replace PY2/3-compatible functionality for unpacking dataset archive files with a faster PY3-only equivalent
  • remove PY2-only logic in io subpackage

Motivation and Context

https://pythonclock.org/

How Has This Been Tested?

All tests pass in PY3 :)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation, and I have updated it accordingly.

@bdewilde bdewilde marked this pull request as ready for review July 23, 2019 22:54
@bdewilde bdewilde merged commit a122fdc into develop Jul 23, 2019
@bdewilde bdewilde deleted the drop-py2-support branch July 23, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant