-
-
Notifications
You must be signed in to change notification settings - Fork 879
Add back apply, bind, and call from Function #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not at a machine right now that I can test this; does this apply to e.g. |
A better option might be to do: Object.setPrototypeOf(Chalk.prototype, Function.prototype); |
@ExE-Boss Hmm, actually,
Shouldn't the prototype chain here be |
The prototype chain is: |
That’s standard ECMAScript behaviour: https://tc39.es/ecma262/#sec-makeconstructor. The This object is used to create new instances by the |
Ahh, of course 🤦♂ Thanks for pointing me in the right direction! Yeah, doing |
Ping @LinusU |
Closing for lack of response. |
Sorry for the lack of response. I don't personally need this anymore since I don't use |
Fixes #388