Skip to content

Conversation

xnox
Copy link
Member

@xnox xnox commented May 13, 2025

Fixes: #48, #65

@xnox xnox merged commit d92eba0 into chainguard-dev:main May 13, 2025
14 of 16 checks passed
@anguslees
Copy link

anguslees commented May 13, 2025

I think the first character of this script is still a newline. I think that makes the #! just a plain old comment (that is ignored), and not a shebang.

@xnox
Copy link
Member Author

xnox commented May 13, 2025

I think the first character of this script is still a newline. I think that makes the #! just a plain old comment (that is ignored), and not a shebang.

thanks, on linux it just works as no shebang is always interpreted as shell.

https://github.com/bazel-contrib/rules_jvm_external/blob/d8af22108bd8b353a226140570008231f2921931/private/rules/maven_publish.bzl#L12 looks like the closest comparable example so will remove newline too, based on that.

@anguslees
Copy link

anguslees commented May 14, 2025

thanks, on linux it just works as no shebang is always interpreted as shell.

Yep.

https://github.com/bazel-contrib/rules_jvm_external/blob/d8af22108bd8b353a226140570008231f2921931/private/rules/maven_publish.bzl#L12 looks like the closest comparable example so will remove newline too, based on that.

Sgtm. See also my backslash suggestion in #65, if you want a different way to format it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Included apko binary does not work
3 participants