Skip to content

Conversation

kiki1607
Copy link
Contributor

Hello,
I update the README.md with adding the NPM badge, the Dependencies badge and the DevDependecies badge. I Hope to have helped you a little bit.

@kiki1607 kiki1607 changed the title Add badges to the README.md chore: Add badges to the README.md Mar 21, 2019
@kiki1607 kiki1607 closed this Mar 21, 2019
@kiki1607
Copy link
Contributor Author

I will reopen the pull request after fixing the problem of the commit name. Sorry for the disturb.

@kiki1607 kiki1607 reopened this Mar 21, 2019
@kiki1607
Copy link
Contributor Author

I'm sorry, but I don't get how to fix this problem... Can you help me? It would help me a lot in the future!

@austince
Copy link
Contributor

austince commented Mar 22, 2019

Hi @kiki1607, thanks for the PR! I think this is a good addition but let's get some feedback from other members.

As for the commit message, the easiest way would be to edit your commit locally and then force push (or with lease) this branch.

git commit --amend # then change the message to something like: 'docs: add badges to the README'
git push --force # if you've set your branch as upstream

You can read more about our commit conventions here.

@vieiralucas
Copy link
Member

Thanks @kiki1607, I agree that this is a great addition too.

@kiki1607 can you follow @austince advice and update the commit message?
Please feel free to ask if you need any further help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants