Add setting migrations for new theme system #2838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyballentine
approved these changes
May 7, 2024
joeyballentine
added a commit
that referenced
this pull request
May 10, 2024
* Add charcoal theme * Fix the themes * auto theming * fix broken theme things * Recompute node headers when theme color changes * Add some more themes * Adjust some colors * Separate dark and light mode selection * Add two more themes * Two more themes * Combine into single list + remove system theme option * Add setting migrations for new theme system (#2838) * Update src/renderer/components/SettingsModal.tsx Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com> * Update src/renderer/components/SettingsModal.tsx Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com> * Add system theme * change how colors get selected a bit * Update src/common/settings/migration.ts Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com> --------- Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there wasn't a way to migrate settings yet, I quickly added one. We can now have any number of settings migrations, and I added the migration to the new theme system to get us started. Migrations are also tested, so we can see the effect of every change we make to settings now.