Skip to content

#2654 add custom tiling option #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 29, 2024
Merged

#2654 add custom tiling option #2828

merged 7 commits into from
Apr 29, 2024

Conversation

the-database
Copy link
Contributor

Adds a custom option to the tile size dropdown to allow entering any tile size.

@the-database
Copy link
Contributor Author

the-database commented Apr 28, 2024 •
edited
Loading

Working on the pyright errors. EDIT: resolved.

joeyballentine
joeyballentine reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just one minor nit

@joeyballentine
Copy link
Member

I think you just need to make it so the check is TileSize(custom_tile_size) if tile_size == CUSTOM and custom_tile_size is not None else tile_size,

@the-database
Copy link
Contributor Author

I think you just need to make it so the check is TileSize(custom_tile_size) if tile_size == CUSTOM and custom_tile_size is not None else tile_size,

Done, thanks!

@joeyballentine
Copy link
Member

Thanks again. I very much appreciate the contributions

@joeyballentine joeyballentine merged commit f971974 into chaiNNer-org:main Apr 29, 2024
@joeyballentine joeyballentine mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-database @joeyballentine