Add Skip existing files option for Save Image & lazy inputs #2808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2807.
This PR adds lazy inputs and uses them to add a "Skip existing files" to Save Image. Lazy inputs work with the
Lazy
type which represent a lazy infallible computation. (WhileLazy
of course handles errors correctly, its users are supposed to assume errors don't happen/pass them up the stack.) This abstraction makes everything pretty easy to implement.One bug that I haven't addressed yet is that lazy inputs mess with node timing. Since the time it takes to evaluate a lazy input currently counts towards both the node being lazily executed and the node evaluating the lazy execution, the time durations of Save Image nodes are wrong.
Not sure if this is a blocker for this PR or whether this can be fixed later.