Fixed SSE request not getting canceled and getting SSE stuck #2806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I discovered an interesting bug: closing a setting doesn't also close currently running requests. This has the effect that our
resp.content.iter_chunks()for our SSE requests just gets stuck and halts forever. This is a problem, because we sometimes restart the worker to kill the current execution. When this bug occurs, the worker will restart and execute chains just fine, but no SSE events will reach the frontend. So no progress updates and broadcasts.I fixed this by manually keeping track of open SSE forward requests and closing them when the worker stops. This causes the SSE forwards to reset properly.