Skip to content

Improved node renaming UX #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2024
Merged

Improved node renaming UX #2752

merged 1 commit into from
Apr 7, 2024

Conversation

RunDevelopment
Copy link
Member

Changes:

  • Disable node renaming in docs. Just like collapsing nodes, it's not useful for docs and just gets in the way.
  • Double-clicking the node header no longer toggles collapsing/expanding the node.
  • Double-clicking the icon or name now toggles renaming. The change is that I included the icon as well, which is necessary. If our users ever find a bug to enter something that is displayed as an empty name, they won't be able to rename the node without the icon also acting as a toggle.
  • Changed design of text box to be closer to the regular header. So the text is now centered and larger.
  • The text box will now fill all available space (and no more).
  • Added input cleaning to normalize spaces.
  • ESC now cancels renaming instead of confirming it. This can be useful sometimes, but I'm not sure whether we should keep this behavior.

image
image

@RunDevelopment RunDevelopment mentioned this pull request Apr 7, 2024
Merged
@joeyballentine
Copy link
Member

ESC now cancels renaming instead of confirming it.

Oh, that's what I thought I had implemented for it anyway, so yeah I think we should keep it

@joeyballentine joeyballentine merged commit c005245 into chaiNNer-org:node-renaming Apr 7, 2024
joeyballentine added a commit that referenced this pull request Apr 7, 2024
@joeyballentine @RunDevelopment
Add ability to rename nodes (#2749)
fe722fa 
* it sorta works

* more usable but still not perfect

* I'm not sure what i messed up

* This works a lot better

* Save nickname in chn file

* remove unused code

* fixes

* Switch to double click header

* get rid of this

* Improved node renaming UX (#2752)

---------

Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
@RunDevelopment RunDevelopment deleted the node-rename-impr branch April 7, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @joeyballentine