Always stop backend before start if updating/installing deps #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was right. This was a general issue caused by us not stopping the worker server (which is using the deps) before updating. So, onnx wasn't able to be deleted since it was locked by the OS.
So, I replaced the restart that only happens if anything installed, to just always stop > install > start. I initially had it this way but changed it since i thought it would optimize startup a bit, but it seems to only cause more issues.
this could potentially be resolved by some refactoring where this bit of code could only stop the server if there is a dep that is already installed that's just being updated, but for now this works.