Clean up files on uninstall #2746
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2347.
Chainner will now delete the
python
andffmpeg
folders when being uninstalled. Some folders and files (e.g. logs and settings) are intentionally left, because they are important and don't take up much space.There are also some electron folders left that cannot be deleted by chainner directly because they are actively used. They only add up to less than 10MB, so they shouldn't be a huge issue.
Since we are now running custom code during (un)install, I also added logging for the (un)installation process. Since I don't trust electron-log while the app is being (un)installed, I rolled my own simple logging solution. It produces an
install.log
file that looks like this:Other changes:
getRootDirSync
togetRootDir
because the name fits better. Sorry for the noisy diff.