Skip to content

Conversation

RunDevelopment
Copy link
Member

Fixes #2347.

Chainner will now delete the python and ffmpeg folders when being uninstalled. Some folders and files (e.g. logs and settings) are intentionally left, because they are important and don't take up much space.

There are also some electron folders left that cannot be deleted by chainner directly because they are actively used. They only add up to less than 10MB, so they shouldn't be a huge issue.

Since we are now running custom code during (un)install, I also added logging for the (un)installation process. Since I don't trust electron-log while the app is being (un)installed, I rolled my own simple logging solution. It produces an install.log file that looks like this:

[2024-04-05T10:08:22.847Z] [INFO] Squirrel command: --squirrel-install
[2024-04-05T10:08:22.849Z] [INFO] Process execPath: C:\Users\micha\AppData\Local\chaiNNer\app-0.22.2\chaiNNer.exe
[2024-04-05T10:10:27.577Z] [INFO] Squirrel command: --squirrel-uninstall
[2024-04-05T10:10:27.579Z] [INFO] Process execPath: C:\Users\micha\AppData\Local\chaiNNer\app-0.22.2\chaiNNer.exe
[2024-04-05T10:10:27.579Z] [INFO] Deleting folder: C:\Users\micha\AppData\Roaming\chaiNNer\ffmpeg
[2024-04-05T10:10:27.592Z] [INFO] Deleting folder: C:\Users\micha\AppData\Roaming\chaiNNer\python

Other changes:

  • I renamed getRootDirSync to getRootDir because the name fits better. Sorry for the noisy diff.

@joeyballentine joeyballentine merged commit 17cd81b into chaiNNer-org:main Apr 5, 2024
@RunDevelopment RunDevelopment deleted the clean-up-unistall branch April 5, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstalling chaiNNer does not remove appdata files
2 participants