Skip to content

Improved node progress API #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2024
Merged

Improved node progress API #2732

merged 2 commits into from
Apr 4, 2024

Conversation

RunDevelopment
Copy link
Member

Changes:

  • Rename NodeProgress to Progress because I intend to use this class as a general progress token throughout chainner in the future.
  • Add sub progress API. This isn't used right now, but will be used for reporting node progress later.
  • Add noop progress. This also will be used later.
  • Add an abort check to PyTorch upscaling to make sure nodes can be aborted properly.

@joeyballentine joeyballentine merged commit 0795b6c into chaiNNer-org:main Apr 4, 2024
@RunDevelopment RunDevelopment deleted the node-progress-impr branch April 4, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @joeyballentine