Fixed slow SSE events #2718
Merged
Fixed slow SSE events #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that SSE events were flow to reach the frontend. Results like View Image and type data are now instant again.
The issue was the SSE proxy had a timeout of 5sec. The total timeout was 5sec. This means that the SSE connection would reset of 5s and each reset took 3~4s to set up a new connection. This was the cause of the inconsistent delays.
The fix is to use a
ClientTimeoutto specify that the SSE connection should time out if it takes longer than 5s to connect to the worker. I set the total timeout to 1h, because it didn't let me set it tofloat("inf").