Make PyTorch upscaling pauseable #2705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for pausing within a PyTorch Upscale Image node.
The implementation of pausing is quite simple. The executor runs all nodes in their own thread (well, it's a thread pool, but close enough), so I can just spin with
time.sleepto allow other threads to run until the execution is resumed. This gives us pausing for minimal effort.Edit: I forgot to mention, alongside pausing, aborting the current execution is also supported within PyTorch upscaling with this PR. So we'll hopefully need to kill the worker less frequently now.