Fix executor passthrough logging #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i didnt know you had to do this
|
One last thing: I think it would be a good idea to give the logged message a prefix, so we know it's from the worker. Maybe something like |
|
I already added [Executor] to it |
joeyballentine
commented
Mar 9, 2024
| match_obj = re.match(SANIC_LOG_REGEX, stripped_line) | ||
| if match_obj is not None: | ||
| log_level, message = match_obj.groups() | ||
| message = f"[Executor] {message.strip()}" |
|
Gonna merge this since I need it for fixing #2646 and I don't think there's anything left to do. If you wanna change the message, just make a followup PR or reply to this and I'll do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest thing I dislike about this is the amount of code that now has to run per-log. This could wind up being a minor performance impact if we have a lot of logging