Server-side execution timeout killing #2646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. I forgot to submit my review... |
|
Of course, since things can't just be easy, now there's an issue where the first request after killing just gets ignored... |
joeyballentine
commented
Mar 13, 2024
| @@ -185,7 +185,7 @@ async def get_sse(self, request: Request): | |||
| "/sse", | |||
| headers=request.headers, | |||
| data=request.body, | |||
| timeout=None, | |||
| timeout=5, | |||
There was a problem hiding this comment.
This seems to have fixed the issue, and I don't think it's caused any side effects
|
I think this is good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the killing of the backend to the backend side, by killing the executor process instead of the entire backend.
This somewhat causes a big problem, which is that when the executor server restarts, it causes the SSE to get stuck/stop working. However, I think this should be solved in a separate PR, since this is actually already an issue with the double-server stuff, that just gets exposed by this change.