Skip to content

Further optimized node selector panel #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RunDevelopment
Copy link
Member

This implements 2 main optimizations: a new NodeRepresentativeList component to share common calculations, and I reduced the DOM nodes it takes to represent a node from 16 to 7.

To reduce DOM nodes, I inlined RepresentativeNode into RepresentativeNodeWrapper.

This also fixes some minor issues:

  • The accent color used to shine through.
    image image
  • Since the old method used outline, dragged node representatives didn't have a border.
    image
    image
  • Text ellipsis works now.
    image
    image

@joeyballentine
Copy link
Member

This is great, thanks for cleaning up my spaghetti

@joeyballentine joeyballentine merged commit 4955328 into chaiNNer-org:main Feb 29, 2024
@RunDevelopment RunDevelopment deleted the node-selector-opt-2 branch February 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants