Make DependencyInfo a data class to simplify code
#2624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyballentine
approved these changes
Feb 28, 2024
joeyballentine
added a commit
that referenced
this pull request
Mar 1, 2024
* first attempt at proxy server * use aiohttp since its faster * more proxying * better proxy method * Separate installing deps and loading nodes * correctly parse packages stuff (mostly) * I spent an hour debugging this.... * remove setup event queue * threads * stuff * dumbest shit i've seen in my life * Add back logging of subprocess * remove proxy logging * remove more unneeded logging * forward SSE requests * Hide internal packages from main packages request * Various cleanup * stop sub server on close * wait for nodes response * change order of events a tad * fix order * Trying something different * maybe this will work better * lint/remove commented code * potential CI fix * add extra index urls to builtin dep installs * technically more correct way to do multiple * safer get * dont pass through flags * revert requests, fix lint * pass in flags only when deps need to be installed temporary * just pyright things * oops * change to for loop * Fix some potential race conditions * fix more potential issues * remove arg print statement * use daemon thread * Make `DependencyInfo` a data class to simplify code (#2624) * Make `DependencyInfo` a data class to simplify code * Minor bug * Attempt to silence FFMPEG more * don't timeout /run requests * PR suggestions --------- Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
DependencyInfoto use optional fields to simplify our declared dependencies.