Skip to content

Conversation

joeyballentine
Copy link
Member

A followup to @mrjschulte's PR (#2606) that allows 1/3/4 channel colors to be used rather than just 4 channel colors.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this color conversion code. Why not create a 1x1 image, use as_target_channels, and then go back to a color with from_1x1_image? This would allow us to use the usual color conversion functions instead of implementing new ones.

@joeyballentine
Copy link
Member Author

To me that seems like it's just adding unnecessary steps, but sure

@RunDevelopment
Copy link
Member

it's just adding unnecessary steps

It kinda is. I mean, it's definitely more work for the CPU, but my goal was to reuse existing code.

@joeyballentine joeyballentine merged commit 8ceea86 into main Feb 26, 2024
@joeyballentine joeyballentine deleted the fix-checkerboard branch February 26, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants