Create "Resolutions" Node #2610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This node provides chaiNNer with a selection of common, and at times industry specific, resolution presets to use as "Number" sources for further use in Chains to help drive other parameters and nodes.
backend/src/packages/chaiNNer_standard/utility/value/formats.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/utility/value/formats.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/utility/value/formats.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/utility/value/formats.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
out with the old....
This node comes with a bunch of presets to help start the user set up their respective chains.
Linting
backend/src/packages/chaiNNer_standard/utility/value/resolutions.py
Outdated
Show resolved
Hide resolved
Adds in assert as requested and adds in support for a custom/user defined resolution, to help keep all of the "magic" numbers pertaining to widht/height in one node.
Sync up all types to int
backend/src/packages/chaiNNer_standard/utility/value/resolutions.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/utility/value/resolutions.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/utility/value/resolutions.py
Outdated
Show resolved
Hide resolved
Remember when I said that? Yeah, we need to change this now... Since you added custom resolutions, the Resolutions node now has 2 number inputs which prevent it from being a starting node. So the node no longer shows the exact resolutions on its outputs. There are 2 ways around this:
Which option you choose should depend on whether you want the "Width" and "Height" input to be connectable. If this isn't necessary, then go with option 1. If you think they should be connectable, then go with option 2 and I'll help you to get the output types right. |
…ns.py Co-authored-by: Joey Ballentine <34788790+joeyballentine@users.noreply.github.com>
…ns.py Co-authored-by: Joey Ballentine <34788790+joeyballentine@users.noreply.github.com>
…ns.py Co-authored-by: Joey Ballentine <34788790+joeyballentine@users.noreply.github.com>
|
Option 1 it is! |
Adds has_handle=False to remove the inputs into the Width/Height as this is a starter node.
joeyballentine
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This node provides chaiNNer with a selection of common, and at times industry specific, resolution presets to use as "Number" sources for further use in Chains to help drive other parameters and nodes.