Skip to content

Conversation

mrjschulte
Copy link
Contributor

The minimap feature enables the user to quickly navigate around a large chaiNNer schematic and also allows for zooming/panning directly within the minimap to help ease schematic navigation.

It shows the entirety of the chaiNNer schematic with all of the nodes and also a highlighted "active window" area within the minimap to show the currently visible focus area.

The minimap is semi transparent to not obscure any of the content behind it.

Screenshot 2024-02-19 at 09 53 11

This adds a minimap to the chaiNNer schematic
This tweaks the default miniMap BG Color to fit in with the default chaiNNer color scheme
more linting, now auto fixed
And now with even more linting! When will it ever stop?
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

It works generally well, but I found 3 things I think we should improve:

  1. The background is a bit too translucent IMO. The mini map isn't very high-contrast, so having nodes be quite visible through the background makes the mini map hard to read.
  2. The zoom change when using the scroll wheel on the mini map is server times larger than in the editor (the node canvas). This is surprising and inconsistent. I think we should make using the scroll wheel in the mini map and in the editor behave the same in terms of zoom change.
  3. Light mode isn't supported. It's usable, but it doesn't fit.
    image

@mrjschulte
Copy link
Contributor Author

Here are the latest versions with more low-contrast theming for both the "light" and "dark" theme options in chaiNNer.

Light:
Screenshot 2024-02-19 at 18 01 57

Dark:
Screenshot 2024-02-19 at 18 01 38

Tweak and move MiniMap background colors to the respective themes
Reduce zoomScroll strength inside of the MiniMap
@RunDevelopment
Copy link
Member

Here are the latest versions with more low-contrast theming

Sorry, you misunderstood. I meant to say that the original theming was too low-contrast and hard to read. Now it's even less readable.

I basically meant to say that I want the background color of the mini map to more opaque. Nodes shining through the background make the mini map hard to read, so 80% opacity (or higher) instead of 66% should make things better.

@joeyballentine
Copy link
Member

Also, can the minimap on light mode be a lighter color than the nodes?

Move the basic MiniMap theming out of the ReactFlow setup and into the global.scss where we can define it for each application "Theme".
Update the MiniMap Theming and define them for each Application Theme.
@mrjschulte
Copy link
Contributor Author

New updates, push comments speak for themselves. New Images below:

Light:
Screenshot 2024-02-20 at 20 34 16

Dark:
Screenshot 2024-02-20 at 20 45 22

Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works great, thanks

@joeyballentine joeyballentine merged commit 2de19b2 into chaiNNer-org:main Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants