Fix Threshold + AA resulting in wrong broadcasting #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary_thresholdfrom chainner_rs returned an image of the shapebinary = (h, w, 1)when given a grayscale image of the shapeimg = (h, w). Multiplying those to image then resulted in an image of the shape(h, w, h)(for some reason) which obviously takes up an insane amount of memory. E.g. an image(4096, 4096, 4096)takes up 256GB of RAM.The fix is to cast
binaryto the shape(h, w)if it's 2D anyway.