Refactored menu #2581
Merged
Refactored menu #2581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyballentine
approved these changes
Feb 11, 2024
|
👍 awesome |
joeyballentine
added a commit
that referenced
this pull request
Feb 11, 2024
* working * Scroll into view when index is out of scroll area * Better scroll behavior * Fix incorrect bound * Automatically select first item when searching * Wrap around + instant scroll * ... * Refactored menu (#2581) --------- Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split between favorites and category groups caused a lot of code duplication in #2575, so I refactored it. The basic idea is that the menu now displays node groups. This makes a few things easier. The abstraction of node categories also means that we have a lot more freedom to restructure the list as much as we want now.
Other changes: