Improved snapping for breakpoints #2577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something with the way you are positioning these now causes the edge to not be perfectly around the circumference. EDIT: this is only for the node-to-breakpoint connections, not the breakpoint-to-breakpoint ones |
|
oh never mind, this is an issue even on my branch and i just hadn't noticed |
joeyballentine
approved these changes
Feb 11, 2024
joeyballentine
added a commit
that referenced
this pull request
Feb 11, 2024
* wip nonworking breakpoints * got it working using a node type * it's working * Revert customedge * Fix breakpoint position * Adjust position and styling * rename class * stylelint is apparently broken for me * Fix the centering issue * Partially curved beziers for the breakpointed edges attached to nodes * fixes * Hold alt + click to add breakpoint * double click to remove breakpoint * Float edges around breakpoint circumference * Fix offset * Snap breakpoints aligned with center * Improved snapping for breakpoints (#2577) Improved snapping * Fix offset issue --------- Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the CSS positions I talked about here. The trick is simple: we have a 1x1 box that is the node, and then we use CSS to absolute position the actual handles.
Other changes:
Centerto center the handles instead of 2Flexcomponents.breakpointsproperty.