Create "Create Colorwheel" node #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new node to the chaiNNer toolset that will allow the user to create a Colorwheel tile at a user defined size.
linting
There was a problem hiding this comment.
The color wheels produced by this node are all slightly off-center because conic_gradient is implemented incorrectly.
Luckily, the fix is pretty simple:
@@ -50,7 +50,7 @@ def conic_gradient(img: np.ndarray, rotation: float = 0):
if rotation < -np.pi:
rotation += 2 * np.pi
- center = np.array(img.shape[:2], dtype="float32") / 2
+ center = (np.array(img.shape[:2], dtype="float32") - 1) / 2
pixels = np.array(
[(r, c) for r in range(img.shape[0]) for c in range(img.shape[1])]
)Could you please add this to your PR?
backend/src/packages/chaiNNer_standard/image/create_images/create_colorwheel.py
Outdated
Show resolved
Hide resolved
fix slight misalignment for center in Conic Gradient per PR feedback.
PR feedback, this node always generates RGB images so annotating that here.
|
Requested Fixes have been made and the PR has been updated. |
RunDevelopment
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new node to the chaiNNer toolset that will allow the user to create a Colorwheel tile at a user defined size.