Skip to content

Icon style for dropdowns #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Feb 6, 2024

This PR adds a new style for dropdowns that displays the options as a list of icon buttons. I used this to make the Text Alignment input of the Text As Image node easier to use.

image
image
image

Other changes:

  • I slightly refactored IconFactory to allow null icons. Since I extracted the props type into its own interface, there was a lot of reformatting...
  • Removed a type case in IconFactory.

Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieht mir gut aus 👍

@joeyballentine joeyballentine merged commit b8768ed into chaiNNer-org:main Feb 6, 2024
@RunDevelopment RunDevelopment deleted the icon-dropdown branch February 6, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants