Create "Log2Lin" node #2546
Merged
Create "Log2Lin" node #2546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This node will apply the Kodak Cineon set of Logarithmic functions to an image.
Linting fix
Undo ruff linter fix for np.ndarray line
Slight refactor for linter and other PR checks.
backend/src/packages/chaiNNer_standard/image_adjustment/adjustments/log2lin.py
Outdated
Show resolved
Hide resolved
…ments/log2lin.py Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
|
The mentioned Kodak Cineon functions are a means to help convert the logarithmic densities encoded on a 0-1 real world medium such as Film Negative into a linear floating point encoding for use in imaging workflows , and vice versa. |
|
Then could you please mention this in the node's description? |
backend/src/packages/chaiNNer_standard/image_adjustment/adjustments/log2lin.py
Outdated
Show resolved
Hide resolved
Clarify Cineon function and rename node to Log To Linear
|
Just FYI, we require all node names to match their function name and file name for ease of searchability. This will actually automatically be changed for you if you run with |
sync up function name with node name change and invert bool option
more cleanup under the hood to address the new node name
linting fix
joeyballentine
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This node will apply the Kodak Cineon set of Logarithmic functions to an image.