Create "Add" node #2528
Merged
Create "Add" node #2528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new chaiNNer node that "adds" values to an input image.
|
Is this functionality not already covered by the Brightness & Contrast node? |
|
I would say that is a form of "combined functionality" in the Brightness/Contrast node. As I plan to add more atomic image processing operations to chaiNNer having individual Core Image processing operators available such as Add, Multiply, Divide, etc allows the users to be much more granular in their processing steps with the application. |
There was a problem hiding this comment.
A few more thoughts I had while reviewing:
- Considering your plan, it might be good to make a new node group for these nodes. You can do that later of course.
- Please note that chainner's images are always in the range 0-1. So if the Add node returns values outside that range, chainner will automatically clip them (with
np.clip(img, 0, 1)).
backend/src/packages/chaiNNer_standard/image_adjustment/adjustments/add.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/image_adjustment/adjustments/add.py
Outdated
Show resolved
Hide resolved
Cleanup and remove unneeded items.
remove unused imports
Anything to make the CI happy!
|
(What's left to do here? @joeyballentine @RunDevelopment ) |
|
Ci, so formatting. |
Ruff says its good, what do ye say?
backend/src/packages/chaiNNer_standard/image_adjustment/adjustments/add.py
Outdated
Show resolved
Hide resolved
Normalize the domain of the Add operation.
linting
joeyballentine
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new chaiNNer node that "adds" values to an input image.