-
-
Notifications
You must be signed in to change notification settings - Fork 322
Change "Note" node styling and make it more versatile #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 6b0cb7a.
Sorry for the delay @joeyballentine!
As I previously suggested, a simple solution would be to make Note a regular node, and let the frontend know about it. The backend node and frontend If you really detest checking schema IDs, you can also add something like a |
Ok, so this now just makes an exception for this node by checking the schema id on the frontend. Some day I'd like to change this, but the way our state is, it just isn't really possible right now. |
A few things:
Also, what do you think about using a WYSIWYG editor like bangle? |
I would like to make this not selectable at least in this PR. I tried very hard to make every element selectable in it, but doing so then leaked selectability and made other things outside of it selectable. I just don't want to deal with that headache right now
I thought of it as more of a visual indicator rather than a usable bar. What would be your recommended course of action for this?
Yeah that looks sick, let's do it. Can I do that in a separate PR though? |
Then let's leave it for now.
Sure. |
Ok, I've:
I think this is good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thank you!
Unlike when I shared this before on Discord, this now just utilizes a new node type, but the schema is still defined on the backend. I still want that to change one day (specifically for this node only, but also for future things such as node groups that will also be implemented as "nodes that are only for visual purposes"). However, chaiNNer's plumbing just simply doesn't allow for this at the moment (at least not without getting a bunch of console errors).