-
-
Notifications
You must be signed in to change notification settings - Fork 322
ONNX upscale reworked #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONNX upscale reworked #2417
Conversation
- removed change_shape flag - reworked like it has been done for pytorch
Revert this change because rife models (even if not supported by chaiNNer) use a different order... |
@adegerard Do you plan to finish this? |
Sorry, I forgot. I ended some tests: I have to check another time grayscale images. I have an implementation which supports this (not commited, and not tested because I currently have no model to test this) |
Sorry that I didn't give context to this. This is common in models exported from tensorflow |
Thanks for finishing it. I'll review it later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for this 👍
Draft PR for information
What has been done
change_shape
flag; assume all models are converted from pytorch (or other) but are in BCHW orderTODO
np2nptensor
andnptensor2np
?