This repository was archived by the owner on Sep 12, 2024. It is now read-only.
fix(alerts): consider subdims inside relevant only if enabled #1140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug existed that appeared in this case:
The bug:
The digest/report sent on that day included subdim anomalies for that KPI in the "Top sub-dimensional anomalies" section even though subdims was disabled.
The cause:
The subdims inside of relevant_subdims were being considered even if include_subdims was set to false. This did not affect subdims that were not associated with an overall anomaly.
The fix:
Add the include_subdims condition to subdims inside relevant_subdims too.