Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

fix(alerts): consider subdims inside relevant only if enabled #1140

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Sep 28, 2022

A bug existed that appeared in this case:

  • An alert is set up with subdims disabled and set to digest/report
  • For the same day, both overall and subdim anomalies are present - (same hour in case of hourly alerts)

The bug:
The digest/report sent on that day included subdim anomalies for that KPI in the "Top sub-dimensional anomalies" section even though subdims was disabled.

The cause:
The subdims inside of relevant_subdims were being considered even if include_subdims was set to false. This did not affect subdims that were not associated with an overall anomaly.

The fix:
Add the include_subdims condition to subdims inside relevant_subdims too.

A bug existed that appeared in this case:
- An alert is set up with subdims disabled and set to digest/report
- For the same day, both overall and subdim anomalies are present
    - (same hour in case of hourly alerts)

The bug:
The digest/report sent on that day included subdim anomalies for that
KPI in the "Top sub-dimensional anomalies" section even though subdims
was disabled.

The cause:
The subdims inside of relevant_subdims were being considered even if
include_subdims was set to false. This did not affect subdims that were
not associated with an overall anomaly.

The fix:
Add the include_subdims condition to subdims inside relevant_subdims
too.
@Samyak2 Samyak2 added 🛠️ backend ❗alerts Alert formatting, scheduling, etc. labels Sep 28, 2022
@Samyak2 Samyak2 added this to the v0.11.0 milestone Sep 28, 2022
@Samyak2 Samyak2 requested a review from Amatullah September 28, 2022 12:00
@gitpod-io
Copy link

gitpod-io bot commented Sep 28, 2022

@netlify
Copy link

netlify bot commented Sep 28, 2022

Deploy Preview for frontend-sb ready!

Name Link
🔨 Latest commit e68569d
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/6334375f70af340008318860
😎 Deploy Preview https://deploy-preview-1140--frontend-sb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Amatullah Amatullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amatullah Amatullah merged commit e877300 into develop Sep 28, 2022
@Amatullah Amatullah deleted the fix/report-subdim-alerts branch September 28, 2022 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
❗alerts Alert formatting, scheduling, etc. 🛠️ backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants